Skip to content

Conversation

@KM-CM
Copy link

@KM-CM KM-CM commented Oct 5, 2025

Why did I close and now am reopening the pull request? Because GitHub did some BS which made it self-close. I didn't close it. It just... did that. Somewhy. I really don't know. So now opening another one...

Now, about your points as stated here.

  1. Sorry. Just sorry, I've got nothin' else to say. EDIT: I do now. I had no idea it was going to your EMAIL. And I did that just in case (don't know why myself, just me being stupid). I had no intention to spam your email or make you hurry ("look through my changes faster").
  2. I think tabs are better than four spaces, but well, fixed it to four spaces now.
  3. You were not actually supposed to see the commits. Not as in they're secret, but as in I've did EXTREMELY small updates, and GitHub saying "KM_CM added a commit" (or whatever it's saying I forgot the exact wording) was never desired by me, it's just the GitHub GUI's thing.

Fixed indentation to four spaces instead of tabs
@buu342
Copy link
Owner

buu342 commented Oct 5, 2025

No worries. I'll take a look at the changes in this PR instead 🙂

@KM-CM
Copy link
Author

KM-CM commented Oct 5, 2025

Sorry for spamming if these messages going to your email, but still gonna say - there's nothing different, other than there being four spaces instead of tabs.

KM-CM added 4 commits October 7, 2025 19:10
Since my changes aren't gonna get merged that quickly, releasing this! :D
...of things that made me question Buu's sanity
-for people to have fun with.
Copy link
Owner

@buu342 buu342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather weapons not be bundled with the weapon base.

...was inconsistent because Notepad++ is hellbent on tabs and Buu loves four spaces.
@KM-CM
Copy link
Author

KM-CM commented Oct 9, 2025

I would rather weapons not be bundled with the weapon base.

I would recommend you include them. If you don't, that's fine. But regardless, here are some reasons to do include them.

  1. They are remakes of Half-Life 2 weapons. That is literally the first thing you should do with a Garry's Mod weapon base IMO.
  2. They don't take that much disk space, they're just a couple extremely short text files.
  3. They showcase the awesome capabilities of your base.

P.S. I am gonna be resolving the spacing issues without any commentary from now on. Because they're just spacing issues. Notepad++, "Find in Files", "\garrysmod\addons\GMod-BuuBaseRedone-Improved\lua", "Search Mode" "Regular expression", "Find what :" "\t", "Replace with :", " "

KM-CM added 7 commits October 12, 2025 16:06
The crosshair spread is actually static. So that makes the crosshair inaccurate when moving. Also fixed the crosshair to display correct spread. There are probably left variables I didn't remove!
Now the curve only happens when you jump. That, and some other optimizations.
@KM-CM
Copy link
Author

KM-CM commented Oct 19, 2025

I've did everything now. Weapons aren't bundled with the base, jumping animation only plays when actually jumping (I still think this is stupid), and... that's pretty much it.

@KM-CM
Copy link
Author

KM-CM commented Oct 31, 2025

Welp, fixed that now! :D

@KM-CM KM-CM requested a review from buu342 November 7, 2025 16:04
@KM-CM
Copy link
Author

KM-CM commented Nov 10, 2025

Now I'm truly done!

@KM-CM
Copy link
Author

KM-CM commented Nov 24, 2025

Sorry for spamming (if this counts as it), and again, I'm not trying to get you to hurry, but... are you still alive? /j

@KM-CM
Copy link
Author

KM-CM commented Dec 6, 2025

Now I know that you're alive since you starred that one repository lol

@buu342
Copy link
Owner

buu342 commented Dec 7, 2025

Like I said, this PR makes a lot of changes, some which I agree and some which I don't. It will take me an entire afternoon to properly review the code and bisect changes that I want. Frankly, I haven't had the time nor patience to do that, and I do not know when I will. I haven't touched Garry's Mod since October.

@KM-CM
Copy link
Author

KM-CM commented Dec 8, 2025

Not a problem, not forcing you to hurry. It's just that you disappeared from everywhere for a lot of time lol

I feel like I'm writing some real freakin' military grade system here xD
@KM-CM
Copy link
Author

KM-CM commented Jan 9, 2026

I have a couple things I would like to note. They are not about your base, but rather if you want to mimic Far Cry 3.

  • Far Cry 3 crosshair growth is different from yours.
  • It also fades out after growing (do note that my addon, KM_CM's Addon, has the almost exact feeling fading out of the crosshair, but you'll have to dig in there yourself, as I am not trying to self-promote 'ere).
  • Nearwall doesn't exist. Far Cry 3 has a cover system (my addon has it too- gets shot 67 times), which is why certain guns go in such positions.

And specifically about your base, for weapons which aren't "fully modeled" as I call them (no, not adult content, as in "made by VALVe in the age when those polygons would never be seen", like HL2 viewmodels), you can use roll as sway.

@KM-CM
Copy link
Author

KM-CM commented Jan 9, 2026

Also, important note. So important I'm leaving a separate comment (jk I just only remembered now). FrameTime() IS FAULTY SOMETIMES! I remember that weapons behaved like 2x faster in multiplayer (on my base which used it), so be careful. The code I wrote prevents ANY possible issue with FrameTime(), by not using it.

@KM-CM
Copy link
Author

KM-CM commented Jan 9, 2026

Also, I never really liked the base. And gave up on it since it conflicts with my addon. But I am still doing this because of the respect I have for it :)

KM-CM added a commit to GarrysMod-KM-CMs-Addon/Base that referenced this pull request Jan 9, 2026
buu342/GMod-BuuBaseRedone#8 (comment)
(The link below may be down after some time since I delete PR repositories after they are merged)
KM-CM/GMod-BuuBaseRedone-Improved@00e9267
@buu342
Copy link
Owner

buu342 commented Jan 10, 2026

I'm not really trying to make Far Cry 3: The SWEP Base, I'm trying to make my base with features that I wanted. Some of those features happen to also be stuff that I enjoyed about Far Cry 3's weapons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants